English clean-up

impaktor
Posts: 729
Joined: Fri Dec 20, 2013 9:54 am
Location: Tellus
Contact:

Re: English clean-up

Post by impaktor » Mon Feb 19, 2018 8:04 am

I've made a branch with your changes:

Diff can be seen here:
https://github.com/impaktor/pioneer/com ... dcce1a69d0

There are far too many changes to be merged without going through the API, and as far as I can see they're all very minor where it basically comes down to personal preference and taste.

Also, I don't know that we have any decision what spelling to use US, UK, Cambridge, Oxford, etc. There are just too many standards, and it's not like there is only one true way to spell in English.

Keeper
Posts: 62
Joined: Thu Jan 04, 2018 9:23 pm
Location: Indian Hills, Nevada, USA
Contact:

Re: English clean-up

Post by Keeper » Tue Feb 20, 2018 12:07 am

Only a few are based on personal taste or preference -- mostly where I added variety to some of the contract text. For example, the disgruntled journalist mentions deadlines, and the disgruntled person on the run from the Mafia uses the vernacular "ain't". Also I changed one pirate taunt's line addressing the player as "Boy" to make it "Kid" so it is not gender-specific.

The vast majority probably are fixing the incorrect use of commas.

NightTripper
Posts: 1
Joined: Sun Apr 29, 2018 6:36 am

Re: English clean-up

Post by NightTripper » Sun Apr 29, 2018 6:50 am

Firstly really excited to see how far this game has come. But this topic did come to mind and was thinking of looking through the code myself as some of the text encountered doesn't read quite right. There are a lot of good fixes in that diff you linked. Making the text much more readable and also removal of some mistakes. There are a few though could argue personal taste, e.g. -ise instead of -ize maybe not necessary and as Keep says some rewording too which probably not essential changes. Maybe a commit with just the basics fixed first?

GunChleoc
Posts: 33
Joined: Sat Nov 30, 2013 12:57 pm
Contact:

Re: English clean-up

Post by GunChleoc » Sun Apr 29, 2018 4:33 pm

-ise instead of -ize will break translations, so it's better not to worry about these. Other languages don't really care about the Cambridge vs. Oxford debate ;)

Actual grammar fixed like discrete -> discreet should go in though.

FluffyFreak
Posts: 1217
Joined: Tue Jul 02, 2013 1:49 pm
Location: Beeston, Nottinghamshire, GB
Contact:

Re: English clean-up

Post by FluffyFreak » Mon Apr 30, 2018 10:38 am

The use of "-ize" is very American from my perspective.

impaktor
Posts: 729
Joined: Fri Dec 20, 2013 9:54 am
Location: Tellus
Contact:

Re: English clean-up

Post by impaktor » Tue May 01, 2018 2:49 pm

My understanding is the -ize (Cambridge style) is actually an older version of British english.

But what really matters:
Image

FluffyFreak
Posts: 1217
Joined: Tue Jul 02, 2013 1:49 pm
Location: Beeston, Nottinghamshire, GB
Contact:

Re: English clean-up

Post by FluffyFreak » Wed May 02, 2018 8:56 am

Walken comma, everytime ;)

Keeper
Posts: 62
Joined: Thu Jan 04, 2018 9:23 pm
Location: Indian Hills, Nevada, USA
Contact:

Re: English clean-up

Post by Keeper » Sat May 05, 2018 10:24 pm

Though in this case the "incorrect use of commas" I'm referring to is using a comma where a period/full-stop or semicolon would be correct. That was quite pervasive throughout the game's text. For example: "Thank you for the delivery, you have been paid in full." A comma is incorrect there.

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest