Page 2 of 3

Re: English clean-up

Posted: Mon Feb 19, 2018 8:04 am
by impaktor
I've made a branch with your changes:

Diff can be seen here:
https://github.com/impaktor/pioneer/com ... dcce1a69d0

There are far too many changes to be merged without going through the API, and as far as I can see they're all very minor where it basically comes down to personal preference and taste.

Also, I don't know that we have any decision what spelling to use US, UK, Cambridge, Oxford, etc. There are just too many standards, and it's not like there is only one true way to spell in English.

Re: English clean-up

Posted: Tue Feb 20, 2018 12:07 am
by Keeper
Only a few are based on personal taste or preference -- mostly where I added variety to some of the contract text. For example, the disgruntled journalist mentions deadlines, and the disgruntled person on the run from the Mafia uses the vernacular "ain't". Also I changed one pirate taunt's line addressing the player as "Boy" to make it "Kid" so it is not gender-specific.

The vast majority probably are fixing the incorrect use of commas.

Re: English clean-up

Posted: Sun Apr 29, 2018 6:50 am
by NightTripper
Firstly really excited to see how far this game has come. But this topic did come to mind and was thinking of looking through the code myself as some of the text encountered doesn't read quite right. There are a lot of good fixes in that diff you linked. Making the text much more readable and also removal of some mistakes. There are a few though could argue personal taste, e.g. -ise instead of -ize maybe not necessary and as Keep says some rewording too which probably not essential changes. Maybe a commit with just the basics fixed first?

Re: English clean-up

Posted: Sun Apr 29, 2018 4:33 pm
by GunChleoc
-ise instead of -ize will break translations, so it's better not to worry about these. Other languages don't really care about the Cambridge vs. Oxford debate ;)

Actual grammar fixed like discrete -> discreet should go in though.

Re: English clean-up

Posted: Mon Apr 30, 2018 10:38 am
by FluffyFreak
The use of "-ize" is very American from my perspective.

Re: English clean-up

Posted: Tue May 01, 2018 2:49 pm
by impaktor
My understanding is the -ize (Cambridge style) is actually an older version of British english.

But what really matters:
Image

Re: English clean-up

Posted: Wed May 02, 2018 8:56 am
by FluffyFreak
Walken comma, everytime ;)

Re: English clean-up

Posted: Sat May 05, 2018 10:24 pm
by Keeper
Though in this case the "incorrect use of commas" I'm referring to is using a comma where a period/full-stop or semicolon would be correct. That was quite pervasive throughout the game's text. For example: "Thank you for the delivery, you have been paid in full." A comma is incorrect there.

Re: English clean-up

Posted: Fri Feb 08, 2019 2:16 am
by Keeper
The ZIP file is updated with files compatible with the current version of Pioneer. This time I didn't bother with standardizing spellings; I just worried about outright mistakes (there/their, discreet/discrete, loose/lose, plus punctuation errors) and the more varied passenger text I had made up.
http://www.keeper1st.com/pioneer/enfixes.zip

I've also gone through the custom system texts.
http://www.keeper1st.com/pioneer/systemstext.zip

For what it's worth, the following other files include additional graphics etc. that I have made, only some of which were incorporated into the new version (I had added more to these ZIP files but the newer ones didn't get put in):
http://www.keeper1st.com/pioneer/gstationpats.zip
http://www.keeper1st.com/pioneer/newtexes.zip
http://www.keeper1st.com/pioneer/newground.zip

And optionally, if you want more colorful cities:
http://www.keeper1st.com/pioneer/buildingsvlastan.zip

Re: English clean-up

Posted: Fri Feb 08, 2019 5:22 pm
by nozmajner
It's kinda hard to see at a glance what you changed on those textures. Could you sum it up?